-
Notifications
You must be signed in to change notification settings - Fork 60
Adds user guide on advanced query classes #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new user guide notebook demonstrating advanced RedisVL query classes (TextQuery, HybridQuery, MultiVectorQuery) and slightly adjusts cleanup formatting in an existing notebook.
- Introduces comprehensive examples for text, hybrid, and multi-vector queries.
- Defines a sample schema and dataset to illustrate query capabilities.
- Replaces a standalone markdown cleanup header with an inline code comment in another guide.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/user_guide/09_advanced_queries.ipynb | New notebook showcasing advanced query classes with schema, data loading, and varied query examples. |
| docs/user_guide/05_hash_vs_json.ipynb | Minor change: removed markdown cleanup header and added a code comment before index deletion. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tylerhutcherson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 2 small comments to take as you wish:
- In hybrid searches, its best practice to use the normalized BM25 scorer so that final scores are properly balanced prior to weighting.
- At the end in the comparison, it could be good to run the same query through all query types and report the top match and score in a clean table for comparison (ideally something that shows the difference?)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR adds a notebook to our RedisVL user guides that demonstrated advanced query classes: TextQuery, HybridQuery, and MultiVectorQuery.